Draft
Conversation
This also removes the registries from the templates/<provider> folders. This is a manual process, but I have confirmed that they are identical as I've moved them.
This is more of a placeholder, but there needs to be a way of excluding common files if required. The k3d providers don't have a registry folder, so a .gitignore might be the way of achieving it. This would need to be merged in with any other .gitignore folders, so we might need a better way of achieving this.
This is not a production system, but a useful way to allow gitops-templates developer to check the files that are generated.
mrsimonemms
force-pushed
the
sje/composable-tpls
branch
from
a08ea1b to
b30ce04
Compare
mrsimonemms
force-pushed
the
sje/composable-tpls
branch
2 times, most recently
from
803cf71 to
e7c92d4
Compare
mrsimonemms
force-pushed
the
sje/composable-tpls
branch
from
e7c92d4 to
c5253b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a first pass at making the template repo composable and reducing the amount of repetition. There are a few key takeaways from this approach:
terraform/git*backend setup is going to be very fiddly. This will likely require a fair bit of duplicationRelated Issue(s)
Fixes #773
How to test